Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle nested value change validation #3926 #3929

Merged
merged 1 commit into from Sep 18, 2022
Merged

fix: handle nested value change validation #3926 #3929

merged 1 commit into from Sep 18, 2022

Conversation

logaretm
Copy link
Owner

@logaretm logaretm commented Sep 17, 2022

By saving a copy of the last value that was watched, we can detect when the watch was triggered due to a nested mutation.

Comparing the old value may seem redundant now, but didn't have time to check that.

closes #3926

@logaretm logaretm self-assigned this Sep 17, 2022
@logaretm logaretm merged commit 771e7f2 into main Sep 18, 2022
@logaretm logaretm deleted the fix/3926 branch September 18, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation not re-running when Array items modified directly
1 participant