Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure validation if we skip checkbox value setting #3927 #3930

Merged
merged 1 commit into from Sep 18, 2022

Conversation

logaretm
Copy link
Owner

@logaretm logaretm commented Sep 18, 2022

What

Fixes #3927 by triggering validation if it should before we skip the value setting aspect of checkboxes.

This issue was caused by the input event being triggered before change event as we try not to toggle the value twice. By mistake, we also avoided validating the value when the change event occurred.

This happens in default settings where change event triggers validation while the input event does not.

@logaretm logaretm self-assigned this Sep 18, 2022
@logaretm logaretm changed the title fix: ensure validation if we skip checkbox value setting closes #3927 fix: ensure validation if we skip checkbox value setting #3927 Sep 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3930 (c12ef9a) into main (cdaf22d) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #3930      +/-   ##
==========================================
- Coverage   96.70%   96.66%   -0.05%     
==========================================
  Files          68       68              
  Lines        1945     1947       +2     
  Branches      484      485       +1     
==========================================
+ Hits         1881     1882       +1     
- Misses         64       65       +1     
Impacted Files Coverage Δ
packages/vee-validate/src/useField.ts 98.44% <50.00%> (-0.51%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@logaretm logaretm merged commit 82d05db into main Sep 18, 2022
@logaretm logaretm deleted the fix/3927 branch September 18, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V4] Inconsistent behaviour with checkbox meta.valid property
2 participants