Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor]: Remove git info from property of ComponentProfile #55

Open
ravut8 opened this issue Nov 9, 2023 · 2 comments
Open

[refactor]: Remove git info from property of ComponentProfile #55

ravut8 opened this issue Nov 9, 2023 · 2 comments
Labels
good first issue Issues that we believe are relatively straightforward to tackle. Good for newcomers.

Comments

@ravut8
Copy link
Contributor

ravut8 commented Nov 9, 2023

Overview

The purpose of this issue is to remove git information from ComponentProfile because issue #6 will add a separate git info which is more detailed and useful in analyzing components. Therefore, we should remove git info from ComponentProfile to ensure better maintainability.

These are 3 places we need to remove vue-scanner.ts

Initial property detail

berryjam/src/vue-scanner.ts

Lines 693 to 697 in 07dc984

dataLastModified: "",
lastModified: "",
created: "",
createdBy: "",
updatedBy: "",

Interface file property

berryjam/src/types.ts

Lines 61 to 65 in 07dc984

created: string;
createdBy: string;
updatedBy: string;
lastModified: string;
dataLastModified: string;

Initial property component

berryjam/src/vue-scanner.ts

Lines 516 to 520 in 07dc984

dataLastModified: "",
lastModified: "",
created: "",
createdBy: "",
updatedBy: "",

There are 2 places to remove from analyze-component-files.spec.ts unit test

  1. dataLastModified: "Fri Apr 28 2023",
    lastModified: "Fri Apr 28 2023",
    created: "2023-04-17T04:04:04.000Z",
    createdBy: "system",
    updatedBy: "system",
  2. dataLastModified: "Fri Apr 28 2023",
    lastModified: "Fri Apr 28 2023",
    created: "2023-04-17T04:04:04.000Z",
    createdBy: "system",
    updatedBy: "system",

Expected Behavior

  • Remove all of them
  • Scan to check that there is no error in exporting components.json
  • Check in components.json that git info is no longer in this JSON file
@ravut8 ravut8 added the good first issue Issues that we believe are relatively straightforward to tackle. Good for newcomers. label Nov 9, 2023
@Nkiriobasi
Copy link

Has this been fix? if not, can I fix it.

@ravut8
Copy link
Contributor Author

ravut8 commented Nov 10, 2023

@Nkiriobasi Thanks for the interest. Please go ahead and assign yourself 😁

Note: When making code contribution, please refer to Contributing for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that we believe are relatively straightforward to tackle. Good for newcomers.
Projects
None yet
Development

No branches or pull requests

2 participants