Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution - Setup Error reproductions #137

Open
Kinfe123 opened this issue Sep 5, 2023 · 2 comments
Open

Contribution - Setup Error reproductions #137

Kinfe123 opened this issue Sep 5, 2023 · 2 comments

Comments

@Kinfe123
Copy link
Contributor

Kinfe123 commented Sep 5, 2023

reproduction for difficulties faced by those who wanted to contribute from clean slate

@Eazash
Copy link
Contributor

Eazash commented Apr 19, 2024

So I'm currently attempting to install dependencies and facing issues with pnpm and node citing client error (ERR_INVALID_THIS)

Reproduction Steps

  • Install node 20 (20.11.1 in my case but any version of node 20 should recreate the issue)
  • Runcorepack enable
  • Run pnpm install
    The error
pnpm install
Scope: all 9 workspace projects
 WARN  Ignoring broken lockfile at /Users/ezra/Projects/OSS/loglib: Lockfile /Users/ezra/Projects/OSS/loglib/pnpm-lock.yaml not compatible with current pnpm
 WARN  GET https://registry.npmjs.org/@clickhouse%2Fclient error (ERR_INVALID_THIS). Will retry in 10 seconds. 2 retries left.
 WARN  GET https://registry.npmjs.org/dotenv error (ERR_INVALID_THIS). Will retry in 10 seconds. 2 retries left.
 WARN  GET https://registry.npmjs.org/kafkajs error (ERR_INVALID_THIS). Will retry in 10 seconds. 2 retries left.
 WARN  GET https://registry.npmjs.org/tsx error (ERR_INVALID_THIS). Will retry in 10 seconds. 2 retries left.
 WARN  GET https://registry.npmjs.org/@auth%2Fcore error (ERR_INVALID_THIS). Will retry in 10 seconds. 2 retries left.
 WARN  GET https://registry.npmjs.org/@libsql%2Fclient error (ERR_INVALID_THIS). Will retry in 10 seconds. 2 retries left.
 WARN  GET https://registry.npmjs.org/@paralleldrive%2Fcuid2 error (ERR_INVALID_THIS). Will retry in 10 seconds. 2 retries left.
 WARN  GET https://registry.npmjs.org/drizzle-kit error (ERR_INVALID_THIS). Will retry in 10 seconds. 2 retries left.
 WARN  GET https://registry.npmjs.org/drizzle-orm error (ERR_INVALID_THIS). Will retry in 10 seconds. 2 retries left.
 WARN  GET https://registry.npmjs.org/@loglib%2Fdb error (ERR_INVALID_THIS). Will retry in 10 seconds. 2 retries left.
 WARN  GET https://registry.npmjs.org/web-vitals error (ERR_INVALID_THIS). Will retry in 10 seconds. 2 retries left.
 WARN  GET https://registry.npmjs.org/react error (ERR_INVALID_THIS). Will retry in 10 seconds. 2 retries left.
 WARN  GET https://registry.npmjs.org/@loglib%2Fconfig error (ERR_INVALID_THIS). Will retry in 10 seconds. 2 retries left.
 WARN  GET https://registry.npmjs.org/@clickhouse%2Fclient error (ERR_INVALID_THIS). Will retry in 1 minute. 1 retries left.
 WARN  GET https://registry.npmjs.org/dotenv error (ERR_INVALID_THIS). Will retry in 1 minute. 1 retries left.
 WARN  GET https://registry.npmjs.org/kafkajs error (ERR_INVALID_THIS). Will retry in 1 minute. 1 retries left.
 WARN  GET https://registry.npmjs.org/tsx error (ERR_INVALID_THIS). Will retry in 1 minute. 1 retries left.
 WARN  GET https://registry.npmjs.org/@auth%2Fcore error (ERR_INVALID_THIS). Will retry in 1 minute. 1 retries left.
 WARN  GET https://registry.npmjs.org/@libsql%2Fclient error (ERR_INVALID_THIS). Will retry in 1 minute. 1 retries left.
 WARN  GET https://registry.npmjs.org/@paralleldrive%2Fcuid2 error (ERR_INVALID_THIS). Will retry in 1 minute. 1 retries left.
 WARN  GET https://registry.npmjs.org/drizzle-kit error (ERR_INVALID_THIS). Will retry in 1 minute. 1 retries left.
 WARN  GET https://registry.npmjs.org/drizzle-orm error (ERR_INVALID_THIS). Will retry in 1 minute. 1 retries left.
 WARN  GET https://registry.npmjs.org/@loglib%2Fdb error (ERR_INVALID_THIS). Will retry in 1 minute. 1 retries left.
 WARN  GET https://registry.npmjs.org/web-vitals error (ERR_INVALID_THIS). Will retry in 1 minute. 1 retries left.
 WARN  GET https://registry.npmjs.org/react error (ERR_INVALID_THIS). Will retry in 1 minute. 1 retries left.
 WARN  GET https://registry.npmjs.org/@loglib%2Fconfig error (ERR_INVALID_THIS). Will retry in 1 minute. 1 retries left.
 WARN  GET https://registry.npmjs.org/@types%2Fnode error (ERR_INVALID_THIS). Will retry in 10 seconds. 2 retries left.
 WARN  GET https://registry.npmjs.org/@loglib%2Fconfig error (ERR_INVALID_THIS). Will retry in 10 seconds. 2 retries left.

The issue seems to be stemming from pnpm, node 20 and node-fetch (see pnpm/pnpm#6424). As a temporary workaround, I downgraded to node 18 (18.18.2) and this issue was gone

@Eazash
Copy link
Contributor

Eazash commented Apr 19, 2024

The lasting solution to this would be either to

  1. upgrade the pnpm version used to at least 8.3.1. However doing that would create issues with pnpm lockfiles being invalid.
  2. upgrading to node 20. This however would mean a lot of packages would break and I don't think this can be done without a full upgrade of package versions throughout the multiple workspaces
  3. Both 1 and 2, might as well jump off the deep end

As a side note, locking the node version needed on the "engines" field would give users a warning when trying to install packages or run scripts. Let me known which path you'd like to follow and I'm happy to create PRs for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants