Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: enterprise connector OIDC Issuer error #5485

Open
sailwebs opened this issue Mar 8, 2024 · 5 comments
Open

bug: enterprise connector OIDC Issuer error #5485

sailwebs opened this issue Mar 8, 2024 · 5 comments
Assignees
Labels
bug Something isn't working status/planned We decided to do it.

Comments

@sailwebs
Copy link

sailwebs commented Mar 8, 2024

Describe the bug

  • pnpm dev
  • addd enterprise connector with OIDC
  • set the Issuer and save the changes
  • an error occurred,
request: /api/sso-connectors/51jtjaelkpu3
response: 
{
    "message": "The connector's config is invalid.",
    "code": "connector.invalid_config",
    "data": {
        "ssoErrorCode": "invalid_config",
        "config": {
            ...
        },
        "message": "fail_to_fetch_config",
        "error": "406: Not Acceptable\n\nAvailable representations: "
    }
}

Possible Causes

I change the code in this way, it will run correctly.

packages/core/src/sso/OidcConnector/utils.ts
image

    const { body } = await got.get(`${issuer}/.well-known/openid-configuration`);
    const result = oidcConfigResponseGuard.safeParse(parseJson(body));
@sailwebs sailwebs added the bug Something isn't working label Mar 8, 2024
@xiaoyijun
Copy link
Contributor

@darcyYe Could you please confirm this issue when you have time?

@darcyYe
Copy link
Contributor

darcyYe commented Mar 11, 2024

Hi @sailwebs, thanks for letting us know about this issue. I'm wondering which IdP you are using? This could help us know whether this is a general or edge case.

@darcyYe darcyYe added the pending-verification Something is still under investigation label Mar 11, 2024
@sailwebs
Copy link
Author

Hi @sailwebs, thanks for letting us know about this issue. I'm wondering which IdP you are using? This could help us know whether this is a general or edge case.

I used kubesphere, which can reproduce this scene.

https://kubesphere.io/

@sailwebs
Copy link
Author

According to the code in my screenshot, it can run normally

image

@darcyYe
Copy link
Contributor

darcyYe commented Mar 28, 2024

Thanks for your reporting, will make the OIDC connector compatible for different response types.

@darcyYe darcyYe added status/planned We decided to do it. and removed pending-verification Something is still under investigation labels Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status/planned We decided to do it.
Development

No branches or pull requests

3 participants