Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate rules or automatically detect tabs #35

Open
mculp opened this issue Mar 9, 2023 · 3 comments
Open

Re-evaluate rules or automatically detect tabs #35

mculp opened this issue Mar 9, 2023 · 3 comments

Comments

@mculp
Copy link

mculp commented Mar 9, 2023

First of all, just wanted to say that this extension is great and was exactly what I was looking for, so thank you for building this.

The problem I’ve run into a couple times is that the browser seems to get in a state where it just stops listening to the extension’s rules.

Additionally, when adding a new rules group, it’d be great if those were added automatically after saving the group. I don’t know if this is happening because my browser is in the bad state I mentioned above, or if it isn’t a feature yet.

A quick fix for this issue (without having to diagnose why my browser ends up ignoring the rules from your extension) would be to have a button to press to "re-evaluate rules" so that it forces all tabs into the groups to which they belong.

If you could point me to the spot in the code that would be best to add this feature, I’d be happy to try to implement it.

@loilo
Copy link
Owner

loilo commented Mar 10, 2023

Hey @mculp. First of all, thanks for the kind words, I'm glad you like the extension.

Generally, the extension should automatically pick up any new groups or changes to existing groups' URL patterns. I have been in your situation before where the extension seemed to be unresponsive to configuration changes, but since this was extremely rare (and never was properly reproducible), I could not pin down the exact cause.

To be honest, I'm kind of opposed to the idea of a "re-evaluation button" because that's exactly not how this extension should work: Configure the groups you need, and never think about the extension again.
That said, the extension malfunctioning of course works against that goal as well. So if you're having this issue on a more regular basis than I do, I'd be very happy if you could provide details that would help with reproducing the problem.

@mculp
Copy link
Author

mculp commented Mar 11, 2023

Totally understand you wanting this to be a "set it and forget it" tool. It's not really a counterpoint, but I think of it like you can refresh in gmail or twitter or how there are ways to "apply rules" or "clear cache" in a lot of apps. I think sometimes you just need to trigger rules manually.

I just have to close my browser and reopen it, which isn't the end of the world but I usually have a lot of tabs open, so it's more of an inconvenience. It's not a big deal, and that's I offered to implement it. :)

FYI, It's happened to me two or three times since I installed it about 7-10 days ago. I haven't picked up on a pattern yet, but I'll let you know if I do.

@loilo
Copy link
Owner

loilo commented Mar 11, 2023

Oof. That's way more often than I hoped for.

Okay, let's see what we can do about this. I could imagine an additional "refresh" entry in the settings, probably also worded in a "this should not happen on a regular basis" way.

Like this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants