Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver Chart Tooltip show undefined for position #29

Closed
loljoho opened this issue Nov 30, 2018 · 3 comments
Closed

Driver Chart Tooltip show undefined for position #29

loljoho opened this issue Nov 30, 2018 · 3 comments
Labels
chart Chart issues
Projects

Comments

@loljoho
Copy link
Owner

loljoho commented Nov 30, 2018

Describe the bug
On the Driver Career Stats page, the tooltip in the position/points chart displays value undefined for position if the driver has more than 50-60 races. For drivers under 50-60 races (51 is as closest as I can get to a cutoff) it displays properly.

Strangely, if you go to /drivers/max_verstappen, for example, some of the values display properly, whereas others do not.

This issue has already been created in the Chart.js repository (see below). It seems to be linked with the use of category as the y-axis type.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any driver's /driver/:driverId page who has more than 50-60 races
  2. Hover over the chart to display the tooltip
  3. See "Position: undefined"

Expected behavior
It should display the position value!

Screenshots
If applicable, add screenshots to help explain your problem.
image
image
image

Additional context
Bug has been reported in Chart.js repository back in August: chartjs/Chart.js#5708

@loljoho loljoho mentioned this issue Nov 30, 2018
3 tasks
@loljoho loljoho added this to To do in v0.1.0 Nov 30, 2018
@loljoho loljoho moved this from To do to Icebox in v0.1.0 Dec 11, 2018
@loljoho
Copy link
Owner Author

loljoho commented Dec 11, 2018

Considering building own wrappers for D3.js in lieu of Chart.js and react-chartjs-2

@loljoho loljoho added the chart Chart issues label Dec 11, 2018
@loljoho
Copy link
Owner Author

loljoho commented Feb 22, 2019

Seems to have been fixed back in December: chartjs/Chart.js#5920

Note: react-chartjs-2 has not been updated since summer 2018.

@loljoho
Copy link
Owner Author

loljoho commented Feb 22, 2019

chart.js is updated to 2.7.3, but the problem persists.

Looking into alternative charting libraries.

@loljoho loljoho closed this as completed Feb 22, 2019
v0.1.0 automation moved this from Icebox to Done Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart Chart issues
Projects
v0.1.0
  
Done
Development

No branches or pull requests

1 participant