Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Someone who understands go and English PLEASE FIX DOCUMENTATION #27

Open
menasheh opened this issue Oct 10, 2017 · 2 comments
Open

Someone who understands go and English PLEASE FIX DOCUMENTATION #27

menasheh opened this issue Oct 10, 2017 · 2 comments

Comments

@menasheh
Copy link

The English in the documentation is very not good. As a beginner to golang and nano, I'm having a lot of trouble understanding it.

Eg;
While handling a message, the handler will receive two arguments, session corresponding a client and a message is the payload of this request that unmarshals by nano automatically.

While handling a message, the handler will receive two arguments, a session id corresponding to a client and a content indicating the payload of the request....

Okay? I had to read through it several times to understand that far.

However, you lost me at unmarshals.

If anyone knows both English and go and nano and can go through the docs it would be a great help...

@lonng
Copy link
Owner

lonng commented Oct 10, 2017

Sorry for my bad English, I will improve the docs later.

@kyle-hy
Copy link

kyle-hy commented Nov 23, 2017

func (c *Group) Member(uid int64) (*session.Session, error) {
c.mu.RLock()
defer c.mu.RUnlock()

for _, s := range c.sessions {  // why no map[]
	if s.UID() == uid {
		return s, nil
	}
}

return nil, ErrMemberNotFound

}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants