Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process stops if recorded video can't be deleted #170

Open
chriskalmar opened this issue Sep 5, 2022 · 0 comments
Open

Process stops if recorded video can't be deleted #170

chriskalmar opened this issue Sep 5, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@chriskalmar
Copy link
Collaborator

Bug description

Process ends suddenly if recorded video can't be deleted.
This happens only if video recording is enabled.
The browser context might be not available anymore, thus causing CI pipeline to fail.

A possible solution would be a try/catch block around:

await page.video()?.saveAs(newVideoPath);
await page.video()?.delete();

How to reproduce

Expected behavior

No response

Lost Pixel information

Configuration prop used in lostpixel.confg.ts to enable video recordings:

   configureBrowser: () => ({
      recordVideo: {
        dir: 'tmp/videos',
        size: {
          width: 1280,
          height: 900,
        },
      },
    }
  }),

lost-pixel logs from CI

video.delete: Target page, context or browser has been closed
@chriskalmar chriskalmar added good first issue Good for newcomers bug Something isn't working labels Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant