Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stories with same name overwrite each others screenshot #206

Open
chriskalmar opened this issue Sep 30, 2022 · 0 comments
Open

Stories with same name overwrite each others screenshot #206

chriskalmar opened this issue Sep 30, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@chriskalmar
Copy link
Collaborator

Bug description

Using the same name for 2 or more stories leads to having the same filename.

This function needs to be refactored:
https://github.com/lost-pixel/lost-pixel/blob/main/src/crawler/storybook.ts#L244-L245

How to reproduce

Run Lost Pixel in storybook mode with at least 2 stories with the same name.

Expected behavior

No response

Lost Pixel information

lost-pixel logs from CI

No response
@chriskalmar chriskalmar added the bug Something isn't working label Sep 30, 2022
@d-ivashchuk d-ivashchuk added the good first issue Good for newcomers label Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chriskalmar @d-ivashchuk