Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing Lost Pixel as dependency breaks Storybook #374

Closed
SrBrahma opened this issue Feb 14, 2024 · 2 comments
Closed

Installing Lost Pixel as dependency breaks Storybook #374

SrBrahma opened this issue Feb 14, 2024 · 2 comments

Comments

@SrBrahma
Copy link
Contributor

Bug description

This is more of an initial Issue as I don't know how to repro it yet, sorry. But it might be useful for the records.

When I install lost-pixel as a devDep, my storybook command stops working with this error:

image

If I uninstall lost-pixel and clean node_modules, the storybook command works again.

I believe that there might be an internal dependency that is causing some sort of conflict with the storybook build system, maybe with babel/webpack.

There is this quite related old issue, but I don't know how it can help:
storybookjs/storybook#11291

For now I will be running the lost-pixel without installing it, with bunx. It works this way!

Although, I lose access to the types, but not a big deal. I am having the config file as .js now.

image

How to reproduce

Expected behavior

No response

Lost Pixel information

"@storybook/addon-a11y": "6.5.16",
"@storybook/addon-actions": "6.5.16",
"@storybook/addon-controls": "6.5.16",
"@storybook/addon-essentials": "6.5.16",
"@storybook/addons": "6.5.16",
"@storybook/builder-webpack4": "6.5.16",
"@storybook/manager-webpack4": "6.5.16",
"@storybook/react": "6.5.16",

"lost-pixel": "3.13.0",

lost-pixel logs from CI

No response

@d-ivashchuk
Copy link
Collaborator

That's totally weird, we don't have dependencies on storybook, but there might be some mutual one indeed. Did you try with some other storybook version?

@SrBrahma
Copy link
Contributor Author

Upgrading it isn't viable at the moment as it would require migrating many stories, although it's planned. Although I believe it would fix this issue.

I will close it as I don't see how we can further investigate it and upgrading it would possibly fix it, but I think it's useful already to have this issue here available for others to find it, if someone steps in the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants