Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fabric][React Native 0.68] Support the new architecture #861

Closed
Alaa-Ben opened this issue Apr 6, 2022 · 14 comments
Closed

[Fabric][React Native 0.68] Support the new architecture #861

Alaa-Ben opened this issue Apr 6, 2022 · 14 comments

Comments

@Alaa-Ben
Copy link

Alaa-Ben commented Apr 6, 2022

Description

Hi !
Lottie doesn't currently support the new Fabric architecture. Are there any plans to ?

@emilioicai
Copy link
Member

We will, but there are some major versions which need to be released in the meantime.

@AlexanderEggers
Copy link
Contributor

@emilioicai I would keen to pick up the work for that. Let me know what you think 😃

@emilioicai
Copy link
Member

Hey @AlexanderEggers that would be great! Let me know if I can support you in any way.

@capezzbr
Copy link

Hey @AlexanderEggers and @emilioicai any update on supporting the new architecture? 🙏

@AlexanderEggers
Copy link
Contributor

@capezzbr I started with the work for that. I hope to have a PR up by the end of this month.

@chenop
Copy link

chenop commented Aug 2, 2022

@AlexanderEggers does that means react-native-lottie does not work on RN 0.68?

@AlexanderEggers
Copy link
Contributor

@chenop No, react-native-lottie should work fine with any newer RN version (tested on 0.68 and 0.69 and no issues so far). But you won't be able to actually enable the new architecture.

@EmreDereli
Copy link

Hey @AlexanderEggers any update about supporting new architecture?

@AlexanderEggers
Copy link
Contributor

@EmreDereli The relevant integration is currently stuck because of an issue with the new arch: facebook/react-native#34372 I hope we will be able to resolve that problem soon.

@alfonsocj
Copy link
Contributor

@AlexanderEggers do you plan to work on the iOS fabric support as well? I can take a look if nobody is working on it yet.

@AlexanderEggers
Copy link
Contributor

@alfonsocj yes I already started with that a little bit but not much progress yet. The underlying new architecture issues are keeping me from progressing at the moment.

@alfonsocj
Copy link
Contributor

Is there a specific new arch issue on iOS or is it same issue you mentioned above (facebook/react-native#34372)?.

@AlexanderEggers
Copy link
Contributor

@alfonsocj It would be unproductive to start working on the new arch for ios unless we get the android setup correct. That setup is still blocked by the mentioned issue.

@AlexanderEggers
Copy link
Contributor

AlexanderEggers commented Oct 16, 2022

I finally managed to get the lib working with fabric. We will do some internal testing to verify that the most of the basic props are working but a release should happen soon. If anyone wants to help the testing effort, feel free to checkout #910.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants