Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slugified emoji turns out as an empty string #35

Open
Betree opened this issue Nov 28, 2019 · 3 comments
Open

Slugified emoji turns out as an empty string #35

Betree opened this issue Nov 28, 2019 · 3 comments
Labels

Comments

@Betree
Copy link
Contributor

Betree commented Nov 28, 2019

Hi, thanks for this awesome library!

We've faced a situation with strings only made of emojis.

Actual behavior

limax('😵️') === ''

Expected behavior

// Replace by emoji name
limax('😵️') === 'dizzy_face'

// Or by emoji code (as when pasted as an URL in the browser)
limax('😵️') === 'xn--w38h'
@lovell
Copy link
Owner

lovell commented Nov 28, 2019

Hi, did you see #31?

@Betree
Copy link
Contributor Author

Betree commented Dec 10, 2019

Hi @lovell, thanks for the reference. Don't you think that would be a nice addition to limax core?

@lovell
Copy link
Owner

lovell commented Dec 10, 2019

Yes, happy to accept a PR if you're able.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants