Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] N-API over Node-ABI #1583

Closed
mubaidr opened this issue Feb 18, 2019 · 2 comments
Closed

[Discussion] N-API over Node-ABI #1583

mubaidr opened this issue Feb 18, 2019 · 2 comments
Labels

Comments

@mubaidr
Copy link

mubaidr commented Feb 18, 2019

Is it possible to update this module to N-API module, seems like a good solution to pre-build problems,
More info: https://nodejs.org/docs/latest/api/n-api.html and https://github.com/nodejs/abi-stable-node
a simple example: https://riptutorial.com/node-js/example/31631/hello-to-n-api

PS. I am fascinated by the performance of this module but at the same time, after updating electron package and nodejs upgrade I have never been able to run my project again due to build issues with this native dependency. Setting up build tools require too much effort but still every now and then something messes it up.

@lovell
Copy link
Owner

lovell commented Feb 18, 2019

Hello, please see #1282 for N-API support and #1522 for details of why the latest Electron 4 doesn't work with native modules (including but not limited to sharp).

@mubaidr
Copy link
Author

mubaidr commented Feb 18, 2019

Ahh missed it. Sorry

@mubaidr mubaidr closed this as completed Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants