Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default page offset to 1 #60

Open
opal06 opened this issue Mar 8, 2023 · 2 comments
Open

Change default page offset to 1 #60

opal06 opened this issue Mar 8, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@opal06
Copy link

opal06 commented Mar 8, 2023

I think that while 0 seems the logical default offset from a programmer's perspective, 1 would actually be a better default as it would fit the average document pagination better. I can make a pull request, but as it's not a big change I wanted to bring it up here first.

Thanks for all the great work, sorry to bother you again!

@lucasrla
Copy link
Owner

lucasrla commented Mar 8, 2023

You're right. It pains me a bit to change a flag's default value (due to backwards compatibility) but having it as 1 is just better long term.

Happy to merge your PR.

Thanks!

@lucasrla lucasrla added the enhancement New feature or request label Mar 8, 2023
@opal06
Copy link
Author

opal06 commented Mar 11, 2023

@lucasrla I see the argument for backwards compatibility, but if someone really depends on the offset being 0, they should still be able to get that behaviour by setting the flag to 0 on program execution, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants