Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): add keyboard-off #1963

Merged
merged 8 commits into from
Apr 9, 2024

Conversation

Diottodev
Copy link
Contributor

@Diottodev Diottodev commented Mar 8, 2024

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

The opposite of keyboard icon

Icon use case

The purpose of this icon is to represent closing/disabling/hiding virtual keyboards

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons: keyboard
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Mar 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

Added or changed icons

icons/keyboard-off.svg

Preview cohesion icons/message-square-code.svg
icons/keyboard-off.svg
icons/octagon.svg
Preview stroke widths icons/keyboard-off.svg
icons/keyboard-off.svg
icons/keyboard-off.svg
DPI Preview (24px) icons/keyboard-off.svg
Icon X-rays icons/keyboard-off.svg

@Diottodev Diottodev changed the title feat(icons): added keyboard-off feat(icons): add keyboard-off Mar 8, 2024
@karsa-mistmere
Copy link
Member

karsa-mistmere commented Mar 8, 2024

Doesn't follow the style of other -off icons, there should be a 2px gap of empty space right of the line.

icons
Open lucide studio

@dan1xk
Copy link

dan1xk commented Mar 8, 2024

this is very useful!

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice icon!!
The metadata should be updated

icons/keyboard-off.json Outdated Show resolved Hide resolved
icons/keyboard-off.json Outdated Show resolved Hide resolved
@ericfennis ericfennis merged commit d75c761 into lucide-icons:main Apr 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants