Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added calendar-cog icon #2176

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

AlexandrePhilibert
Copy link
Contributor

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Adds a calendar with a cog in the bottom right.

Icon use case

Can be used in the following circumstances:

  • Settings related to a calendar
  • Settings related to events

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

Sorry, something went wrong.

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jun 1, 2024
Copy link

github-actions bot commented Jun 1, 2024

Added or changed icons

icons/calendar-cog.svg

Preview cohesion icons/square-menu.svg
icons/calendar-cog.svg
icons/snail.svg
Preview stroke widths icons/calendar-cog.svg
icons/calendar-cog.svg
icons/calendar-cog.svg
DPI Preview (24px) icons/calendar-cog.svg
Icon X-rays icons/calendar-cog.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const CalendarCogIcon = createLucideIcon('CalendarCog', [
  ["path",{"d":"m15.2 16.9-.9-.4"}],
  ["path",{"d":"m15.2 19.1-.9.4"}],
  ["path",{"d":"M16 2v4"}],
  ["path",{"d":"m16.9 15.2-.4-.9"}],
  ["path",{"d":"m16.9 20.8-.4.9"}],
  ["path",{"d":"m19.5 14.3-.4.9"}],
  ["path",{"d":"m19.5 21.7-.4-.9"}],
  ["path",{"d":"M21 10.5V6a2 2 0 0 0-2-2H5a2 2 0 0 0-2 2v14a2 2 0 0 0 2 2h6"}],
  ["path",{"d":"m21.7 16.5-.9.4"}],
  ["path",{"d":"m21.7 19.5-.9-.4"}],
  ["path",{"d":"M3 10h18"}],
  ["path",{"d":"M8 2v4"}],
  ["circle",{"cx":"18","cy":"18","r":"3"}]
])

@jguddas
Copy link
Member

jguddas commented Jun 1, 2024

Cleaned up

icons
Open lucide studio

Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@AlexandrePhilibert
Copy link
Contributor Author

AlexandrePhilibert commented Jun 1, 2024

@jguddas I've applied your changes, let me know if there's anything else I need to do.

{
"$schema": "../icon.schema.json",
"contributors": [
"karsa-mistmere",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the people from the original calendar and cog icon you used here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already added karsa-mistmere and ericfennis that are the contributors to the two icons I based mine on.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, looks like I messed up and didn't add myself when I redid the cogs in #1225

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @AlexandrePhilibert , love it!

Copy link
Member

@karsa-mistmere karsa-mistmere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericfennis ericfennis requested a review from jguddas June 5, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants