fix: improve proto checking for hgetall [skip ci] #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in #1417
luin
changed the title
TysonAndre
reviewed
Aug 18, 2021
There was a problem hiding this comment.
lgtm, documentation of https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/in#parameters in operator is what I'd expect it to be
| expect(ret[CUSTOM_PROPERTY]).to.eql("world"); | ||
| expect(Object.keys(ret).sort()).to.eql( | ||
| ["__proto__", CUSTOM_PROPERTY].sort() | ||
| ); |
There was a problem hiding this comment.
Unrelated to this change: Could also check that expect(Object.getPrototypeOf(ret)).to.eql(Object.prototype); to confirm the original prototype isn't overridden, though the Object.keys() check pretty much implies that
|
🎉 This PR is included in version 4.27.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this pull request
Mar 1, 2024
## [4.27.9](redis/ioredis@v4.27.8...v4.27.9) (2021-08-30) ### Bug Fixes * Fix undefined property warning in executeAutoPipeline ([#1425](redis/ioredis#1425)) ([f898672](redis/ioredis@f898672)) * improve proto checking for hgetall [skip ci] ([#1418](redis/ioredis#1418)) ([cba83cb](redis/ioredis@cba83cb))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1417