Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong typing for maxRetriesPerRequest in ioredis v5? #1550

Closed
soulchild opened this issue Mar 29, 2022 · 2 comments · Fixed by #1553
Closed

Wrong typing for maxRetriesPerRequest in ioredis v5? #1550

soulchild opened this issue Mar 29, 2022 · 2 comments · Fixed by #1553
Labels
released typing

Comments

@soulchild
Copy link

The documentation states that we may set maxRetriesPerRequest to null to get pre-v4 behaviour:

Set maxRetriesPerRequest to null to disable this behavior, and every command will wait forever until the connection is alive again (which is the default behavior before ioredis v4).

Unfortunately, the types included in v5 only allow number values for this option. Is this a bug?
@luin
Copy link
Collaborator

luin commented Mar 29, 2022

Yeah it's a bug. The option should accept null. Thanks for pointing this out!

@luin luin added the typing label Mar 29, 2022
luin added a commit that referenced this issue Mar 30, 2022
@luin
fix: allow option maxRetriesPerRequest to be null
4318faf 
Closes #1550
@luin luin mentioned this issue Mar 30, 2022
Merged
luin added a commit that referenced this issue Mar 30, 2022
@luin
fix: allow option maxRetriesPerRequest to be null (#1553)
d62a808 
Closes #1550
github-actions bot pushed a commit that referenced this issue Mar 30, 2022
@ioredis-robot @semantic-release-bot
chore(release): 5.0.2 [skip ci]
92e7cd9 
## [5.0.2](v5.0.1...v5.0.2) (2022-03-30)

### Bug Fixes

* allow option maxRetriesPerRequest to be null ([#1553](#1553)) ([d62a808](d62a808)), closes [#1550](#1550)
* support TypeScript interface as parameters of hmset and mset ([#1545](#1545)) ([3444791](3444791)), closes [#1536](#1536)
@github-actions
Copy link

🎉 This issue has been resolved in version 5.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

janus-dev87 added a commit to janus-dev87/ioredis-work that referenced this issue Mar 1, 2024
@janus-dev87
chore(release): 5.0.2 [skip ci]
628c848 
## [5.0.2](redis/ioredis@v5.0.1...v5.0.2) (2022-03-30)

### Bug Fixes

* allow option maxRetriesPerRequest to be null ([#1553](redis/ioredis#1553)) ([d62a808](redis/ioredis@d62a808)), closes [#1550](redis/ioredis#1550)
* support TypeScript interface as parameters of hmset and mset ([#1545](redis/ioredis#1545)) ([3444791](redis/ioredis@3444791)), closes [#1536](redis/ioredis#1536)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow option maxRetriesPerRequest to be null redis/ioredis
2 participants
@soulchild @luin