fix: send correct command during auto-pipelining of .call() operations #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Thanks for the contribution! |
|
🎉 This PR is included in version 5.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
kylecannon
pushed a commit
to kylecannon/ioredis
that referenced
this pull request
Dec 8, 2023
redis#1579) Co-authored-by: Zihua Li <i@zihua.li>
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this pull request
Mar 1, 2024
## [5.0.5](redis/ioredis@v5.0.4...v5.0.5) (2022-05-17) ### Bug Fixes * improve typing for redis.multi ([#1580](redis/ioredis#1580)) ([f9f875b](redis/ioredis@f9f875b)) * send correct command during auto-pipelining of .call() operations ([#1579](redis/ioredis#1579)) ([e41c3dc](redis/ioredis@e41c3dc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using custom
.call()operations (such as.call("FT.SEARCH", "index", ...)) in combination with auto-pipelining, the resulting redis command would not include theFT.SEARCHcommand itself.callitself is defined as the result ofgenerateFunction("call", "utf8")which shifts the command out of the args array into a separate variablecommandNameand then usesfunctionName(call),commandName(FT.SEARCH) andargs(index, ...) to callexecuteWithAutoPipelining.executeWithAutoPipelininghowever completely ignores thecommandNameand assumes that thefunctionNameis what we're actually trying to execute when it forwards the command topipeline[functionName](...args);. As far as I can tell, we can't just usecommandNameinstead offunctionNamein here since the pipeline object itself isn't prepared for arbitrary commands so we have to keep referring to it ascallbut we can unshift the actualcommandNameback into the arguments which will successfully make it into the command.