Fixes passing in family parameter in URL in node 18 #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 18 stopped coercing the type for its options (specifically the ip family option) and instead throws an error. So if you pass in `?family=6` in your Redis URL, it would fail because when it does the DNS lookup passing in the string `'6'`, node would throw an error.
|
Thanks for the contribution! 🍺 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
## [5.2.4](v5.2.3...v5.2.4) (2022-11-02) ### Bug Fixes * passing in family parameter in URL in node 18 ([#1673](#1673)) ([6f1ab9f](6f1ab9f))
|
🎉 This PR is included in version 5.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this pull request
Mar 1, 2024
## [5.2.4](redis/ioredis@v5.2.3...v5.2.4) (2022-11-02) ### Bug Fixes * passing in family parameter in URL in node 18 ([#1673](redis/ioredis#1673)) ([6f1ab9f](redis/ioredis@6f1ab9f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 18 stopped coercing the type for its options (specifically the ip family option) and instead throws an error. So if you pass in
?family=6in your Redis URL, it would fail because when it does the DNS lookup passing in the string'6', node would throw an error.Fixes #1672