Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The syntax highlighting stops working on nested items #18

Closed
markmals opened this issue Sep 2, 2018 · 4 comments
Closed

The syntax highlighting stops working on nested items #18

markmals opened this issue Sep 2, 2018 · 4 comments
Labels
bug Something isn't working

Comments

@markmals
Copy link

markmals commented Sep 2, 2018

screen shot 2018-09-01 at 7 05 41 pm

@lukakerr
Copy link
Owner

lukakerr commented Sep 4, 2018

I assume you're using tabs for indentation, as with spaces the syntax highlighting works, except even with spaces the actual bullet * or - still doesn't get syntax highlighted for nested items. Unfortunately I use the Highlightr library for syntax highlighting, so there's not much I can do apart from raise an issue, or convert tabs to spaces automatically which I'm sure some people wouldn't like

@markmals
Copy link
Author

markmals commented Sep 4, 2018

Yes, using tabs. Highlightr seems to be relatively well maintained still, so perhaps raising an issue there might convince them to fix this.

Have you considered any other syntax highlighting libraries? It's not necessarily more currently maintained or more stable, but SyntaxKit was built specifically for a Markdown app and supports any tmLanguage and tmTheme files, which are pretty ubiquitous and used by Visual Studio Code. Also it's fully native and doesn't rely on JavaScript.

@lukakerr
Copy link
Owner

lukakerr commented Sep 4, 2018

Since I use Highlightr for the app themeing as well, it might be tricky to move to a different library, but I’ll take a look at them and see if it’s possible, since using tmLanguage/tmTheme files would open up the ability to use colour schemes already out there

@lukakerr lukakerr added the bug Something isn't working label Feb 13, 2019
@lukakerr
Copy link
Owner

Just FYI, this has been fixed. I fixed it myself in the end in a PR to highlight.js - highlightjs/highlight.js#2004. The result is shown below:

Screen Shot 2019-03-13 at 3 53 03 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants