Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow resources in jsdomConfig #37

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow resources in jsdomConfig #37

wants to merge 3 commits into from

Conversation

fstanis
Copy link

@fstanis fstanis commented Nov 6, 2019

Fixes #36

@fstanis fstanis mentioned this pull request Nov 6, 2019
Open
lukechilds
lukechilds requested changes Nov 8, 2019
View reviewed changes
Copy link
Owner

@lukechilds lukechilds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we can load both the user supplied ResourceLoader and the ones hardcoded in window?

src/index.js Outdated Show resolved Hide resolved
@fstanis @lukechilds
Update src/index.js
8cb7939 
Co-Authored-By: Luke Childs <lukechilds123@gmail.com>
@fstanis
Copy link
Author

fstanis commented Nov 9, 2019

Not sure I understand, what's hardcoded in window in terms of ResourceLoader?

@lukechilds
Copy link
Owner

lukechilds commented Nov 15, 2019 •
edited

Sorry, misunderstanding on my end, this is all good. Could you just fix the lint errors and then this is good to merge?

@fstanis
Copy link
Author

fstanis commented Nov 28, 2019

Should be all good now.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ee1e974 on fstanis:patch-1 into 82c7830 on lukechilds:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukechilds lukechilds lukechilds requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom ResourceLoader support
3 participants
@fstanis @lukechilds @coveralls