Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular #8

Open
lukeed opened this issue Aug 29, 2018 · 6 comments
Open

Angular #8

lukeed opened this issue Aug 29, 2018 · 6 comments
Labels
NEW preset Related to a "preset" package

Comments

@lukeed
Copy link
Owner

lukeed commented Aug 29, 2018

Add new @pwa/preset-angular package.

I'm super out of touch with Angular, so this will need some research.

@lukeed lukeed added NEW preset Related to a "preset" package labels Aug 29, 2018
@MarkRabey
Copy link

I've worked with Angular a fair amount. It's best used with @angular/cli, and uses TypeScript. I'd love to help implement. I've forked the repo for that reason. I'll probably do it any, but if for some reason you're against it, let me know.

@lukeed
Copy link
Owner Author

lukeed commented Sep 6, 2018

Hey, awesome! That would be great! Although, I'd expect that to likely be an involved PR, just a heads up 😜

Does Angular now require TS, or is it just part of standard convention?

Either way, I have a TS plugin mostly complete. If Angular does require TS, we'd build off/alongside that plugin as opposed to installing all of TS & co in the Angular preset a second time.

@housseindjirdeh
Copy link

This is an awesome project, and I'm definitely excited to see it grow to include an Angular preset :)

AFAIK, you can't bootstrap a new Angular CLI project without TS.

Some additional notes (in case it helps):

  • The CLI has support for style preprocessers (less, scss and stylus are all supported if I'm not mistaken). Can start a new project with one like this:
    • ng new new-app --style=scss
  • @angular/router is how routing is built into the framework. It also supports lazy loading different feature modules out of the box
  • @angular/pwa can be used to add a service worker to an Angular CLI app

@lukeed
Copy link
Owner Author

lukeed commented Sep 7, 2018

Awesome, thank you @housseindjirdeh ~!

All sounds good, thanks. So then that definitely places #5 as a pre-req 👍

Those other behaviors should be working out of the box. If Angular works like 99.9% of everything else, it's just a matter of emitting the particular content type(s) into the Webpack sphere & allowing the delegated-n-designated loaders handle the rest.

There's some good visibility here so far, so I'll definitely come back with questions since I haven't meddled w/ Angular since early 2.x 👻

That is, if @MarkRabey doesn't beat me to it 🙌

@MarkRabey
Copy link

Sorry, I've hit a wall, so to speak, in terms of time. While I'd love to help out with this, it's probably best someone else take care of it. I've barely had time to think about it the past few days.

@lukeed lukeed mentioned this issue Sep 11, 2018
3 tasks
@lukeed
Copy link
Owner Author

lukeed commented Sep 11, 2018

Not to worry @MarkRabey! However much or little (or none) you're able to contribute is super appreciated. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NEW preset Related to a "preset" package
Projects
None yet
Development

No branches or pull requests

3 participants