Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Benchmarks section to run with latest Node.js LTS version (v16) #195

Open
micalevisk opened this issue Feb 21, 2022 · 2 comments
Open

Comments

@micalevisk
Copy link

uvu/readme.md

Lines 115 to 117 in 86725b4

## Benchmarks
> via the [`/bench`](/bench) directory with Node v10.21.0

Can you run the benchmarks again with node 16.x? v10 is now too old. I don't have any dedicated VM run them by myself.


Thank you for this lib ❤️

@jmcdo29
Copy link

jmcdo29 commented Mar 20, 2022

FWIW I ended up running them on my machine, and after some tinkering with some package.json's I got these results:
uvu/bench at   on  fix/before-error-reporting [ ] via  v16.13.0                                                                                                                    7m ⚑
❯ node .
~> "ava" took 567ms
    ||
    ||
    ||    ✔ sum
    ||    ✔ div
    ||    ✔ mod
    ||    ─
    ||
    ||    3 tests passed
    ||
~> "jest" took 910ms
    ||
    ||  PASS suites/jest/index.spec.js
    ||    sum
    ||      ✓ should be a function (1 ms)
    ||      ✓ should compute values correctly (1 ms)
    ||    div
    ||      ✓ should be a function
    ||      ✓ should compute values correctly (1 ms)
    ||    mod
    ||      ✓ should be a function
    ||      ✓ should compute values correctly (1 ms)
    ||
    ||  Test Suites: 1 passed, 1 total
    ||  Tests:       6 passed, 6 total
    ||  Snapshots:   0 total
    ||  Time:        0.471 s
    ||  Ran all test suites matching /suites\/jest/i.
    ||
~> "mocha" took 187ms
    ||
    ||
    ||
    ||    sum
    ||      ✓ should be a function
    ||      ✓ should compute result correctly
    ||
    ||    div
    ||      ✓ should be a function
    ||      ✓ should compute result correctly
    ||
    ||    mod
    ||      ✓ should be a function
    ||      ✓ should compute result correctly
    ||
    ||
    ||    6 passing (6ms)
    ||
    ||
~> "tape" took 97ms
    ||
    ||  TAP version 13
    ||  # sum
    ||  ok 1 should be strictly equal
    ||  ok 2 should be strictly equal
    ||  ok 3 should be strictly equal
    ||  ok 4 should be strictly equal
    ||  # div
    ||  ok 5 should be strictly equal
    ||  ok 6 should be strictly equal
    ||  ok 7 should be strictly equal
    ||  ok 8 should be strictly equal
    ||  # mod
    ||  ok 9 should be strictly equal
    ||  ok 10 should be strictly equal
    ||  ok 11 should be strictly equal
    ||  ok 12 should be strictly equal
    ||
    ||  1..12
    ||  # tests 12
    ||  # pass  12
    ||
    ||  # ok
    ||
    ||
~> "uvu" took 50ms
    ||
    ||  index.js
    ||  • • •   (3 / 3)
    ||
    ||    Total:     3
    ||    Passed:    3
    ||    Skipped:   0
    ||    Duration:  0.94ms
    ||
    ||

@iambumblehead
Copy link

As well, benchmarks should be updated to include ava4 rather than ava3. Including node's native test-runner would be great as well https://nodejs.org/api/test.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants