Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save relative position of the drawing to the elements on the page #14

Open
Stvad opened this issue Apr 29, 2022 · 1 comment
Open

Save relative position of the drawing to the elements on the page #14

Stvad opened this issue Apr 29, 2022 · 1 comment

Comments

@Stvad
Copy link

Stvad commented Apr 29, 2022

Right now when I use the extension and

  • scroll using mouse -> the drawing moves on the screen while underlying content remains in place
  • scroll using the scrollbar -> the underlying content moves, but drawing remains in place

scrawl-scroll

Expected behavior would be for the drawing to stay in the same relative position to the element on the page when I scroll

Resizing the page causes similar issues (but seems harder to solve)

@lukesmurray
Copy link
Owner

resizing is probably completely out of scope since resizing changes the layout on most pages. scrolling may be possible but my gut feeling is repositioned drawings would be approximately rather than exactly correct. I am open to pull requests but for now I view this project as a prototype rather than a product. While scrolling would be awesome it creates a new surface area for bugs and adds additional maintenance burden which I can't take on at the moment.

If you really want to see this project develop feel free to send pull requests, if they're reasonable I'll add you as a contributor and if it picks up enough traction we could spin off the project into its own org. I would love to see this project grow but don't have the time to make it happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants