fix(pop): expose pop in api #72
Merged
+23
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lundberg
requested changes
Sep 4, 2020
respx/api.py
Outdated
| @@ -30,6 +30,11 @@ def reset() -> None: | |||
| mock.reset() | |||
|
|
|||
|
|
|||
| def pop(alias: Optional[str] = None) -> RequestPattern: | |||
There was a problem hiding this comment.
I'd like to see this global pop to expose the same functionality as the one(s) on the transport, i.e. alias should not be optional and a default should be allowed.
Also, the overloading would be nice.
lundberg
reviewed
Sep 18, 2020
respx/api.py
Outdated
Comment on lines
6
to
7
| DefaultType = TypeVar("DefaultType", bound=Any) | ||
|
|
There was a problem hiding this comment.
Just a minor, maybe this DefaultType could be moved to models.py, to be used both in api and transports modules, instead of duplicating?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #70