Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align API with HTTPX changes #79

Closed
2 of 4 tasks
lundberg opened this issue Sep 23, 2020 · 9 comments · Fixed by #93
Closed
2 of 4 tasks

Align API with HTTPX changes #79

lundberg opened this issue Sep 23, 2020 · 9 comments · Fixed by #93
Labels
enhancement New feature or request

Comments

@lundberg
Copy link
Owner

lundberg commented Sep 23, 2020

HTTPX public API has seen some changes lately that should be addressed and aligned with in RESPX.

When adding patterns/responses, RESPX should support:

@lundberg lundberg added the enhancement New feature or request label Sep 23, 2020
@bowenwr
Copy link

bowenwr commented Sep 30, 2020

Looking forward to this, as I currently have a conflict with a dependency that requires httpx 0.15.4.

@lundberg
Copy link
Owner Author

Current respx release supports httpx 0.15.4.

Did you mean something else, or have more detail on what respx could help solving your conflict @bowenwr ?

Feedback welcome!

@jairhenrique
Copy link
Contributor

@lundberg can you release an version on pypi with supports httpx 0.15?

poetry lock

Updating dependencies
Resolving dependencies... (0.3s)

[SolverProblemError]
Because respx (0.12.1) depends on httpx (>=0.14,<0.15)
 and no versions of respx match >0.12.1,<0.13.0, respx (>=0.12.1,<0.13.0) requires httpx (>=0.14,<0.15).
So, because ... depends on both httpx (^0.15.4) and respx (^0.12.1), version solving failed.

@mkuokkanen
Copy link

mkuokkanen commented Sep 30, 2020

Hi, we are using respx 0.12.1 and poetry shows this to me

respx 0.12.1 A utility for mocking out the Python HTTPX and HTTP Core libraries.
└── httpx >=0.14,<0.15

Notice the upper limit <0.15. So having respx as dependency prevents us from upgrading to httpx 0.15.4. Looking forward for the latest changes. :)

edit: jairhenrique and me got hit by the same problem at the same time it seems :D

@bowenwr
Copy link

bowenwr commented Sep 30, 2020

@lundberg I'm having the exact problem @jairhenrique is having:

[SolverProblemError]
Because no versions of respx match >0.12.1,<0.13.0
 and respx (0.12.1) depends on httpx (>=0.14,<0.15), respx (>=0.12.1,<0.13.0) requires httpx (>=0.14,<0.15).
And because openapi-python-client (0.6.1) depends on httpx (^0.15.4)
 and no versions of openapi-python-client match !=0.6.1, respx (>=0.12.1,<0.13.0) is incompatible with openapi-python-client.
So, because openapi-specs depends on both openapi-python-client (*) and respx (^0.12.1), version solving failed.

@lundberg
Copy link
Owner Author

@lundberg can you release an version on pypi with supports httpx 0.15?

Absolutely, released 0.13.0 now, sorry for the delay.

@lundberg
Copy link
Owner Author

Notice the upper limit <0.15. So having respx as dependency prevents us from upgrading to httpx 0.15.4. Looking forward for the latest changes. :)

I removed the HTTPX upper limit in 0.13.0 @mkuokkanen . No need to have an upper limit, if it works with later HTTPX version then great, if not we still need to fix it ;-)

@bowenwr
Copy link

bowenwr commented Sep 30, 2020

Thanks so much @lundberg, 0.13.0 solved my issue!

@mkuokkanen
Copy link

Super quick, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants