Allow lowercase method strings in .add #80
Conversation
| @@ -226,7 +226,7 @@ def __init__( | |||
| self.pass_through = None | |||
| self._match_func = method | |||
| else: | |||
| self.method = method | |||
| self.method = method.upper() | |||
There was a problem hiding this comment.
Is this a decent approach?
We could also make a top level constant respx.GET == "GET"
and encourage folk to use that instead of the string literals (think this is what they do in responses land)?
There was a problem hiding this comment.
I think this is the correct place and way to solve the issue.
About the constants, I'd say we skip them to align with HTTPX. If HTTPX adds constants for the http methods in the future, then those can be uses with RESPX.
|
Better if I squash the commits that are: linting, updating from master and removing the debugging commented out stuff? |
| request = respx_mock.add(method_str, url, content=content) | ||
| response = await getattr(client, client_method_attr)(url) | ||
| assert request.called is True | ||
| assert response.json() == content |
There was a problem hiding this comment.
should we also be testing the respx.add way of doing this like in test_mock.py::test_start_stop?
| @@ -226,7 +226,7 @@ def __init__( | |||
| self.pass_through = None | |||
| self._match_func = method | |||
| else: | |||
| self.method = method | |||
| self.method = method.upper() | |||
There was a problem hiding this comment.
I think this is the correct place and way to solve the issue.
About the constants, I'd say we skip them to align with HTTPX. If HTTPX adds constants for the http methods in the future, then those can be uses with RESPX.
| request = respx_mock.add(method_str, url, content=content) | ||
| response = await getattr(client, client_method_attr)(url) | ||
| assert request.called is True | ||
| assert response.json() == content |
Co-authored-by: Jonas Lundberg <jonas@5monkeys.se>
Added - Added `text`, `html` and `json` content shorthands to ResponseTemplate. (PR #82) - Added `text`, `html` and `json` content shorthands to high level API. (PR #93) - Added support to set `http_version` for a mocked response. (PR #82) - Added support for mocking by lowercase http methods, thanks @lbillinghamtn. (PR #80) - Added query `params` to align with HTTPX API, thanks @jocke-l. (PR #81) - Easier API to get request/response from call stats, thanks @SlavaSkvortsov. (PR #85) - Enhanced test to verify better content encoding by HTTPX. (PR #78) - Added Python 3.9 to supported versions and test suite, thanks @jairhenrique. (PR #89) Changed - `ResponseTemplate.content` as proper getter, i.e. no resolve/encode to bytes. (PR #82) - Enhanced headers by using HTTPX Response when encoding raw responses. (PR #82) - Deprecated `respx.stats` in favour of `respx.calls`, thanks @SlavaSkvortsov. (PR #92) Fixed - Recorded requests in call stats are pre-read like the responses. (PR #86) - Postponed request decoding for enhanced performance. (PR #91) - Lazy call history for enhanced performance, thanks @SlavaSkvortsov. (PR #92) Removed - Removed auto setting the `Content-Type: text/plain` header. (PR #82)
Fixes #76
MockTransport().add("get", ...)now works the same asMockTransport().add("GET", ...)