Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.9 to test matrix #89

Merged
merged 1 commit into from Oct 9, 2020
Merged

Conversation

jairhenrique
Copy link
Contributor

No description provided.

Copy link
Owner

@lundberg lundberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

There are two minor coverage issues in the new 3.9 coverage report.

Please try to solve those, for 100% on all version, and we're good to merge.

@jairhenrique
Copy link
Contributor Author

@lundberg I will try to debug it.

@lundberg
Copy link
Owner

lundberg commented Oct 8, 2020

@lundberg I will try to debug it.

Great. Seams like the lines are covered, but not the path to exit for some reason in 3.9??

@jairhenrique
Copy link
Contributor Author

@lundberg I think that's a coverage issue. I put a breakpoint before raise line and the tests pass many times there.

Screen Shot 2020-10-09 at 08 49 38

@lundberg
Copy link
Owner

lundberg commented Oct 9, 2020

@lundberg I think that's a coverage issue. I put a breakpoint before raise line and the tests pass many times there.

Yep, I think you're right. I'll consider this OK.

@lundberg lundberg merged commit 772ee6b into lundberg:master Oct 9, 2020
lundberg added a commit that referenced this pull request Oct 15, 2020
Added
- Added `text`, `html` and `json` content shorthands to ResponseTemplate. (PR #82)
- Added `text`, `html` and `json` content shorthands to high level API. (PR #93)
- Added support to set `http_version` for a mocked response. (PR #82)
- Added support for mocking by lowercase http methods, thanks @lbillinghamtn. (PR #80)
- Added query `params` to align with HTTPX API, thanks @jocke-l. (PR #81)
- Easier API to get request/response from call stats, thanks @SlavaSkvortsov. (PR #85)
- Enhanced test to verify better content encoding by HTTPX. (PR #78)
- Added Python 3.9 to supported versions and test suite, thanks @jairhenrique. (PR #89)

Changed
- `ResponseTemplate.content` as proper getter, i.e. no resolve/encode to bytes. (PR #82)
- Enhanced headers by using HTTPX Response when encoding raw responses. (PR #82)
- Deprecated `respx.stats` in favour of `respx.calls`, thanks @SlavaSkvortsov. (PR #92)

Fixed
- Recorded requests in call stats are pre-read like the responses. (PR #86)
- Postponed request decoding for enhanced performance. (PR #91)
- Lazy call history for enhanced performance, thanks @SlavaSkvortsov. (PR #92)

Removed
- Removed auto setting the `Content-Type: text/plain` header. (PR #82)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants