Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LVGL 9 lv_group_add_obj unecessary steps? #5955

Closed
xamix opened this issue Mar 25, 2024 · 3 comments · Fixed by #6124
Closed

LVGL 9 lv_group_add_obj unecessary steps? #5955

xamix opened this issue Mar 25, 2024 · 3 comments · Fixed by #6124
Labels
stale

Comments

@xamix
Copy link

xamix commented Mar 25, 2024 •
edited

LVGL version

V9.1.1

What happened?

Hi,

I need some clarification on lv_group_add_obj function.

At line 123 there is a call to be sure the object is removed from its current group.
However at line 126 there is a check to do not add the object twice, this is unecessary since it was removed previously?
Also at line 135 it check if the object is already in a group and focused then it refocus it, but it will never occur if the object was previously removed from it's group?

Regards

How to reproduce?

No response
@kisvegabor
Copy link
Member

True! In light of that this whole section can be removed. Could you send a Pull request?

@lvgl-bot
Copy link

We need some feedback on this issue.

Now we mark this as "stale" because there was no activity here for 14 days.

Remove the "stale" label or comment else this will be closed in 7 days.

@lvgl-bot lvgl-bot added the stale label Apr 25, 2024
kisvegabor added a commit to kisvegabor/lvgl_upstream that referenced this issue Apr 25, 2024
@kisvegabor
chore(group): remove useless code
d631f38 
fixes lvgl#5955
@kisvegabor kisvegabor mentioned this issue Apr 25, 2024
Merged
@kisvegabor
Copy link
Member

I've opened #6124 to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(group): remove useless code kisvegabor/lvgl_upstream
3 participants
@kisvegabor @xamix @lvgl-bot