Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between local and non-local files with thumbnails #643

Open
tsujan opened this issue Mar 3, 2021 · 4 comments
Open

Distinguish between local and non-local files with thumbnails #643

tsujan opened this issue Mar 3, 2021 · 4 comments

Comments

@tsujan
Copy link
Member

tsujan commented Mar 3, 2021

libfm-qt has an option to make thumbnails only for local files but that option has no effect for now (pcmanfm-qt inherits it in its Preferences dialog).

@stefonarch
Copy link
Member

It works here with samba, showing or not thumbnails on the other PC following setting in PCMan, maybe I miss something.

@tsujan
Copy link
Member Author

tsujan commented Mar 3, 2021

@stefonarch, the code does absolutely nothing.

@tsujan
Copy link
Member Author

tsujan commented Mar 3, 2021

Here, the problem is distinguishing between local and remote files. A native file may be remote (like a file in Google drive, mounted locally by rclone) and a non-native file can be local (like trash:///).

I tested by adding GLib's G_FILE_ATTRIBUTE_FILESYSTEM_REMOTE to libfm-qt (in 2 ways). It worked with trash (= local), smb (= remote) and sftp (= remote) but not with Google drive (should be remote but is considered local) and, probably, similar cases.

There's another GLib's attribute G_FILE_ATTRIBUTE_FILESYSTEM_USE_PREVIEW but it's mysterious to me and I didn't find it in the codes of well-known GTK file managers.

@tsujan
Copy link
Member Author

tsujan commented Mar 5, 2021

I think the safest way of giving sense to that option is tolerantly considering "local" as "native". There is a good reason: most external thumbnailers — if not all — only work with native paths and, for example, can't make thumbnails inside trash:/// or recent:/// (while the built-in thumbnailer can). In this way, we'll have a more self-consistent thumbnail handling.

EDIT: Tested it but didn't like it. The above-mentioned reason seems good but, for example, having thumbnails with google drive isn't good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants