Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing pasting of full path into "File name" entry? #962

Closed
tsujan opened this issue Apr 15, 2024 · 4 comments · Fixed by #964
Closed

Allowing pasting of full path into "File name" entry? #962

tsujan opened this issue Apr 15, 2024 · 4 comments · Fixed by #964
Assignees

Comments

@tsujan
Copy link
Member

tsujan commented Apr 15, 2024

That wouldn't be self-consistent for obvious reasons, but since Qt's default file dialog supports it, we might also want to do so.

If it's going to be done, the implementation should be as self-consistent as possible— for example, the completer should work if the pasted path is inside the current directory, or the path may need to be removed in that case,… — hence self-assigning.

@tsujan tsujan self-assigned this Apr 15, 2024
@rodrigo-j-goncalves
Copy link

May I mention the discussion/rationale for context? Here.

@tsujan
Copy link
Member Author

tsujan commented Apr 15, 2024

Will be done after LXQt 2.0.0 (which will be released soon) because, contrary to the appearances, it'll need several considerations and thorough testing.

@rodrigo-j-goncalves
Copy link

Cool!! Thank you so much for considering this!!!

tsujan added a commit that referenced this issue Apr 20, 2024
A path can be absolute or relative and can be used with file opening and saving alike.

Also, two minor issues are revealed and fixed after this change:

 * A mistake is corrected in the logic of showing error message about nonexistent files.
 * An issue is fixed in updating accept button on changing directory.

NOTE: Although this isn't self-consistent, Qt's default file dialog supports it. It can also be useful when the path is already copied from somewhere. The extra code is kept to a minimum.

Closes #962
tsujan added a commit that referenced this issue Apr 30, 2024
A path can be absolute or relative and can be used with file opening and saving alike.

Also, two minor issues are revealed and fixed after this change:

 * A mistake is corrected in the logic of showing error message about nonexistent files.
 * An issue is fixed in updating accept button on changing directory.

NOTE: Although this isn't self-consistent, Qt's default file dialog supports it. It can also be useful when the path is already copied from somewhere. The extra code is kept to a minimum.

Closes #962
@tsujan
Copy link
Member Author

tsujan commented May 2, 2024

@rodrigo-j-goncalves
The PR is here: #964. If you have LXQt 2.0.0 and can make package from source, please test it. Otherwise, we're testing it, and it'll be in 2.1.0 if there's no issue.

tsujan added a commit that referenced this issue May 23, 2024
A path can be absolute or relative and can be used with file opening and saving alike.

Also, two minor issues are revealed and fixed after this change:

 * A mistake is corrected in the logic of showing error message about nonexistent files.
 * An issue is fixed in updating accept button on changing directory.

NOTE: Although this isn't self-consistent, Qt's default file dialog supports it. It can also be useful when the path is already copied from somewhere. The extra code is kept to a minimum.

Closes #962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants