Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mingw64] [xavs2 git] #2680

Closed
lopes143 opened this issue May 13, 2024 · 5 comments
Closed

[mingw64] [xavs2 git] #2680

lopes143 opened this issue May 13, 2024 · 5 comments

Comments

@lopes143
Copy link

...
libbluray git  .............................................. [Up-to-date]
xavs 0.1  ................................................... [Up-to-date]
  Running git update for xavs2...
┌ xavs2 git  .......................................... [Recently updated]
├ Running uninstall...
├ Running configure...
├ Running install...
Likely error (tail of the failed operation logfile):
      |                                             ^~~~
      |                                             |
      |                                             char **
C:/media-autobuild/build/xavs2-git/source/encoder/parameters.c:531:62: note: expected 'const char * const*' but argument is of type 'char **'
  531 | static char *xavs2_get_configs(int argc, const char * const *argv)
      |                                          ~~~~~~~~~~~~~~~~~~~~^~~~
C:/media-autobuild/build/xavs2-git/source/encoder/parameters.c:626:11: warning: unused variable 'map_index' [-Wunused-variable]
  626 |     int   map_index;
      |           ^~~~~~~~~
make: *** [Makefile:266: encoder/parameters.o] Error 1
install failed. Check C:/media-autobuild/build/xavs2-git/build/linux/ab-suite.install.log
This is required for other packages, so this script will exit.
  Creating diagnostics file...

Attach C:\media-autobuild\build\logs.zip to the GitHub issue.
Make sure the suite is up-to-date before reporting an issue. It might've been fixed already.

Try running the build again at a later time.

logs.zip

@mojie126
Copy link

A temporary solution can solve the problem of compilation passing. Whether it can be repaired is awaiting official confirmation.

#2677

@lopes143
Copy link
Author

lopes143 commented May 14, 2024

I applied the patch, but when I run the build script again, it updates the xavs2 build to the no-patch version. I can't avoid it revering back to the bad version although I marked avs2 as "No" in the initial options.

parameters.c after patch and before script running
parameters.c after patch and before script running

console log after applying patch and running again the script
console log after applying patch and running again the script

parameters.c after running the script - revering the patch
parameters.c after running the script - it keeps reverting the patch

@mojie126
Copy link

Because ma will check git when compiling
Add below this line

    do_vcs "$SOURCE_REPO_XAVS2"; then
    do_wget -c -r -q "https://raw.githubusercontent.com/mojie126/ma/main/patch/xavs2/0001_xavs2_encoder_parameters.patch" "0001_xavs2_encoder_parameters.patch"
    git apply "0001_xavs2_encoder_parameters.patch"

@lopes143
Copy link
Author

Thank you. It worked

@piegit
Copy link

piegit commented May 15, 2024

Because ma will check git when compiling Add below this line

    do_vcs "$SOURCE_REPO_XAVS2"; then
    do_wget -c -r -q "https://raw.githubusercontent.com/mojie126/ma/main/patch/xavs2/0001_xavs2_encoder_parameters.patch" "0001_xavs2_encoder_parameters.patch"
    git apply "0001_xavs2_encoder_parameters.patch"

Where do I put the text?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants