Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better tests #10

Open
buschtoens opened this issue Jun 19, 2018 · 0 comments
Open

Add better tests #10

buschtoens opened this issue Jun 19, 2018 · 0 comments

Comments

@buschtoens
Copy link
Collaborator

The README states it quite nicely:

weaksauce test

馃槃

I also added a lot of new stuff in #8 that is virtually untested. We'll need to improve our testing story.

Requirements:

  • test code for:
    • JavaScript
      • native class syntax: class extends { ... }, with Babel 6 workaround
      • Ember object model: EmberObject.extend({ ... })
    • TypeScript
      • native class syntax: class extends { ... }, without Babel 6 workaround
      • Ember object model: EmberObject.extend({ ... }), optional
  • assert that @task works without options
  • assert that @task works with options and actually applies these modifiers
  • assert that @taskGroup works without options
  • assert that @taskGroup works with options and actually applies these modifiers
  • test that the joint decorators, e.g. @restartableTask and @restartableGroup work as expected
  • no need to assert that ember-concurrency works as it should, but can be expected in order to aid in writing tests

Maybe we can do the joint decorators in some sort of generative way in order to reduce the amount of test code we need to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant