Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying timeout(s) #71

Open
AlexandreUnlatch opened this issue Sep 7, 2021 · 3 comments
Open

Specifying timeout(s) #71

AlexandreUnlatch opened this issue Sep 7, 2021 · 3 comments

Comments

@AlexandreUnlatch
Copy link

AlexandreUnlatch commented Sep 7, 2021

I may be mistaken but I didn't find any options to specify a timeout.

It seems to me that 2 types of timeouts could be implemented.

  • Stopping the job after x amount of time. This could be achieved in a run statement, but having an argument like "job-timeout" or such could be useful.

  • Terminating the ec2 instance after x amount of time. To reduce the risk of paying for an unused EC2 instance if any edge case, where that could happen, was to happen. Self terminating the ec2 instance might be a way to implement this behavior. An argument "ec2-timeout" might then be appropriate.

@mikemhenry
Copy link

I was going to ask about the same thing, another mechanism to consider is https://docs.aws.amazon.com/AWSEC2/latest/WindowsGuide/UsingAlarmActions.html#AddingTerminateActions
Perhaps during the start-runner we can use some of the AWS API to setup an alarm that will terminate the instance after some time.

@jpalomaki
Copy link
Collaborator

Stopping the job after x amount of time

Which job?

@AlexandreUnlatch
Copy link
Author

Hi !
The first bullet point actually refers to github actions job timeout and is thus already implemented 👍

Only the one for terminating the ec2 may be useful to add !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants