We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recently, our team found an arbitrary order detail access vulnerability in the latest version of the project.
The vulnerability logic is present in the file: https://github.com/macrozheng/mall-swarm/blob/master/mall-portal/src/main/java/com/macro/mall/portal/service/impl/OmsPortalOrderServiceImpl.java#L390
The developer failed to check the ownership of the orderId with the access user when querying the order details via orderMapper.selectByPrimaryKey(), leading to any order can be traversed by /order/detail/{orderId} to get details (i.e., https://github.com/macrozheng/mall-swarm/blob/master/mall-portal/src/main/java/com/macro/mall/portal/controller/OmsPortalOrderController.java#L86), leaking user privacy data (e.g., address, phone number, etc.)
orderId
orderMapper.selectByPrimaryKey()
/order/detail/{orderId}
We recommend that developers add the access control policy before querying via orderId to ensure that the accessor is the owner of the order.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Recently, our team found an arbitrary order detail access vulnerability in the latest version of the project.
The vulnerability logic is present in the file: https://github.com/macrozheng/mall-swarm/blob/master/mall-portal/src/main/java/com/macro/mall/portal/service/impl/OmsPortalOrderServiceImpl.java#L390
The developer failed to check the ownership of the
orderId
with the access user when querying the order details viaorderMapper.selectByPrimaryKey()
, leading to any order can be traversed by/order/detail/{orderId}
to get details (i.e., https://github.com/macrozheng/mall-swarm/blob/master/mall-portal/src/main/java/com/macro/mall/portal/controller/OmsPortalOrderController.java#L86), leaking user privacy data (e.g., address, phone number, etc.)We recommend that developers add the access control policy before querying via
orderId
to ensure that the accessor is the owner of the order.The text was updated successfully, but these errors were encountered: