Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What about to Donate the SourceCode to Apache NetBeans #128

Open
gilbertoca opened this issue Aug 20, 2019 · 32 comments
Open

What about to Donate the SourceCode to Apache NetBeans #128

gilbertoca opened this issue Aug 20, 2019 · 32 comments

Comments

@gilbertoca
Copy link

Dear @madflow and @stengerh ,

This plugin is really popular among NetBeans users and I would like to ask you the possibility of the source code donation to Apache NetBeans, so it can be an integral part of all Netbeans ecosystem?
WTA?

ref: apache/netbeans#1428
@madflow
Copy link
Owner

madflow commented Aug 20, 2019

@gilbertoca @jlahoda I personally would embrace the idea that Markdown would become a 1st class citizen in Netbeans. Most of the source code has been written by @stengerh and @junichi11 . The MIT License would allow a transition without asking every contributor I would assume. I would still like to here some opinions on this (but, everyone could just adopt/fork it without asking permissions).

A blocker is this issue in my opinion: #121

Pegdown was the perfect fit back in the days - now the plugin will need a Markdown parser update to perform at its best.

@jlahoda
Copy link

jlahoda commented Aug 20, 2019

@matthiasblaesing, would you have any insights on what could be a way to get this plugin to be part of NetBeans itself?

Regarding the parser, I'll try to find some to look at the parsers, but cannot make promises.

@Chris2011
Copy link

Please also have a look at this ticket #121. It's about using other parsers than the deprecated pegdown.

@junichi11
Copy link
Collaborator

@madflow I respect your opinion because this is your repo ;)

@matthiasblaesing
Copy link

This is my understanding of the Apache Legal FAQ: We can include MIT licensed code into the netbeans code base. When we do this, we still have to follow the requirements of the license. We would therefor be required to include the MIT copyright information. We have a similar case in the smooth scrolling code in the "Look & Feel Customization Library":

https://github.com/apache/netbeans/blob/master/platform/o.n.swing.plaf/licenseinfo.xml#L47..L56

here the ALv2 is worse than the MIT license. For the MIT license, I would reference the license and be done with it, the ALv2 requires us to clutter the NOTICE file with this.

My take on this:

  • if it is possible to gather all people that contributed to the project and let them transfer their work/copyright to a single author, who then donates it to the ASF would be the best (yeah, probably won't happen)
  • alternative 1: Get all contributors to agree on a relicensing to ALv2 without a NOTICE file (have a look at our NOTICE file or the lucene one and you know, that they are a very bad idea)
  • alternative 2: The code gets contributed as is and the license file of netbeans gets one more entry

@madflow
Copy link
Owner

madflow commented Aug 30, 2019 •
edited

I am really not familiar how to "contribute/donate" source code to bigger project like Netbeans. I have never heard of a NOTICE file before. I am open to "asking" all 8 Contributors if they would object relicensing if this would make things easier. I would favor alternative 2.

@stengerh
Copy link
Collaborator

stengerh commented Nov 9, 2019

Sorry for the late response. I was swamped with work for the last months and must have missed the notification.

I would agree on a relicensing. Alternative 2 would be fine for me as well if someone else objects to a relicensing.

@Chris2011
Copy link

So do we still need to donate the code? Afaik, @jlahoda already started it: apache/netbeans#1428 also he started to add flexmark. So I think the code for donation is incompatible?

@jlahoda
Copy link

jlahoda commented Apr 6, 2020

My patch was for just highlighting - the donation would give us more fully featured support. I think the more fully featured support would be much better - and my PR could just be closed as not needed anymore.

@Chris2011
Copy link

Ok, thx for letting me know. And to add this here, donating the code will still use the old and deprecated pegdown lib. Just to let you know.

@ve3
Copy link

ve3 commented Nov 19, 2020

This plugin is not working anymore in Netbeans 12.1.

@thomas-mc-work
Copy link

On my machine it's still working with NetBeans 12.1. Did you try a fresh install, @ve3 ?

@ve3
Copy link

ve3 commented Nov 19, 2020 •
edited

On my machine it's still working with NetBeans 12.1. Did you try a fresh install, @ve3 ?

Yes, I tried that but when it was installed and restart the plugin did not appear in the list and not functional.

I'm using Windows 10 x64 Netbeans 12.1.

@agarcialeon
Copy link

I can confirm that 2.3.2 version works on NetBeans 12.3 (Preview works, navigator and syntax highlighting).
Anyway, it's anyone working on an update to flexmark? Is there any ETA?

Because my company has switched to Netbeans as a publisher, I have made a list of plugins, themes and other resources so that other developers can more easily find the links after seeing that the plugins portal is down.

@Chris2011
Copy link

There was another Markdown plugin: https://github.com/jkost/MarkdownViewerForNetBeans. @jkost is on it, but has some trouble. What is your list, that you mentioned?

@agarcialeon
Copy link

Is this one: Awesome Netbeans.
I'm using the "awesome" kind of repo for this since I haven't found any other with enough contents and I already have other lists to help me gather resources.

@Chris2011
Copy link

Oh that's great, thx :). We should tweet about it and send them around. This is a great resource.

@Chris2011
Copy link

BTW: apache/netbeans#1428 there is now basic syntax highlighting coming in NetBeans 12.4 added by @jlahoda. Just syntax highlighting. Converting to see the result is still missing and can be handled in an other ticket with flexmark. e.g.

@agarcialeon
Copy link

Ah, good to see it! Will check it when I have more free time. Thanks for the info.

@ve3
Copy link

ve3 commented Apr 29, 2021

I cannot even install.
Download from this page https://github.com/madflow/flow-netbeans-markdown/releases/tag/2.3.2 ( flow-netbeans-markdown.nbm )

Try to install with Netbeans 12.3 but error.

The validation of downloaded plugins cannot be completed, cause: NBM ...\flow-netbeans-markdown.nbm needs unpack200 to process following entries:
...

@Chris2011
Copy link

Chris2011 commented Apr 29, 2021 •
edited

@ve3 that is because of your JDK that you use. From one specific JDK version, I think >= JDK 14, they removed the unpack200 package. So workaround is to use another JDK < 14 to run it with NetBeans and install the plugin and then switch back if really needed. This happens, for some plugins that have packed stuff within.

@agarcialeon
Copy link

@ve3 that is because of your JDK that you use. From one specific JDK version, I think >= JDK 14, they removed the unpack200 package. So workaround is to use another JDK < 14 to run it with NetBeans and install the plugin and then switch back if really needed. This happens, for some plugins that have packed stuff within.

I link to stackoverflow with the same response as @Chris2011.
For reference, @ve3 I'm using OpenJDK 11.0.10.9.

@jkost
Copy link

jkost commented Apr 30, 2021 via email

@agarcialeon
Copy link

The book you refer is already added. But I can link the other ones.
About the plugins list, I wasn't aware of it. Definitely will add it too. But yes, I can contribute to the website with the content listed there.

@agarcialeon
Copy link

@jkost do you have updated links for the blogs? I have already added the books to the list.

@jkost
Copy link

jkost commented May 4, 2021 via email

@jkost
Copy link

jkost commented May 4, 2021 via email

@thomas-mc-work
Copy link

While I like your engagement around Netbeans, I'd prefer to keep the comments in this issues aligned to the topic. I think it would be better to place these hints in the issues sections of that respective repository.

Thanks!

@Chris2011
Copy link

In the discussions section would be better. FYI.

@agarcialeon
Copy link

I agree with @thomas-mc-work and I have added @jkost references to the list and opened threads in the discussions section of the repository to not pollute this repository issue. Thanks again @Chris2011 for the tip.

agarcialeon added a commit to agarcialeon/awesome-netbeans that referenced this issue May 5, 2021
@agarcialeon
Update README.md
92b72ad 
Added more books referenced here: madflow/flow-netbeans-markdown#128 (comment)
@jkost
Copy link

jkost commented May 5, 2021 via email

@geertjanw
Copy link

There's interest in continuing to develop this plugin and also the source code would be welcome at Apache NetBeans to be continued there: apache/netbeans#3477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests