Use _final instead of _flush #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2018
|
Any news about this fix? |
|
@jomaora waiting for feedback from @mafintosh |
piglovesyou
added a commit
to piglovesyou/pipeline-pipe
that referenced
this pull request
Sep 29, 2019
…i-flush-to-final I respectfully merged Tapppi/parallel-transform/tree/flush-to-final Refs. mafintosh#4 Refs. mafintosh#6 # Conflicts: # index.js # package.json
|
I respectfully merged this into my public package |
bcomnes
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that node 8 and
readable-streaminclude the_finalmethod, we should use that when closing down instead of_flushto make sure all processing is done before'finish'event fires.The only change should be that the
Writableside of the transform does not close after everything has been passed to transform function but after everything has been processed, as should happen according to node docs.Fixes #4