fix: making endings clear and final. #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinheidegger
force-pushed
the
clear-end
branch
3 times, most recently
from
902bc2d
to
7ea4b4f
Compare
I just ran into this issue myself. I monkey patched around it with this: // HACK
// this is a specific issue that's waiting on https://github.com/streamxorg/streamx/pull/46
// -prf
hyperswarmSocket._ended = false
const _end = hyperswarmSocket.end
hyperswarmSocket.end = function (data: any) {
_end.call(this, data)
this._ended = true
}
Object.defineProperty(hyperswarmSocket, 'writable', {
get() {
return !this._ended && this._writableState !== null ? true : undefined
}
}) |
martinheidegger
force-pushed
the
clear-end
branch
from
7ea4b4f
to
7abb35b
Compare
This comment has been minimized.
This comment has been minimized.
martinheidegger
force-pushed
the
clear-end
branch
from
7abb35b
to
164761f
Compare
martinheidegger
force-pushed
the
clear-end
branch
from
a71e088
to
6bbafd6
Compare
martinheidegger
force-pushed
the
clear-end
branch
from
6bbafd6
to
6879a60
Compare
|
Rebase to the latest changes, though it looks like 9d3eed0 defines the current behavior as desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to add clear end operations to streamx.
If
.push(null)or.end()are called for a second time, streamx will now throw an Error alerting the user to that misuse of the API.This PR fixes some incompatibility with Node.js (.writable becomes false after end).
Closes #44, #45