Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename internal hooks #54

Open
mafintosh opened this issue Feb 1, 2022 · 0 comments
Open

Rename internal hooks #54

mafintosh opened this issue Feb 1, 2022 · 0 comments

Comments

@mafintosh
Copy link
Owner

After hitting a few "user errors", I think we should rename the following internal hooks for clarity (semvar major, but public api the same)

  • _destroy (cb) --> _close(cb)
  • _predestroy() -> _destroy(err)

_close to better reflect that its the opposite of _open and _destroy to indicate that this is the "intercept the statemachine and destroy as soon as you can" hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant