Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling pipe option to keep writer open #86

Open
steverep opened this issue Apr 30, 2024 · 1 comment
Open

Handling pipe option to keep writer open #86

steverep opened this issue Apr 30, 2024 · 1 comment

Comments

@steverep
Copy link

The streamx implementation for the pipe() method takes a callback as the 2nd parameter, whereas the native Node pipe() takes an options object. Currently the only option is to possibly keep the destination writer open.

I got burned on the upgrade from Gulp v4 to v5 (which now uses streamx) because streamx seems to simply silently ignore the parameter if { end: false } is passed.

As a fix, it would be helpful if streamx threw an error unless a proper callback was passed as the 2nd parameter to avoid such issues.

And as a feature, it would be nice if streamx supported an option to keep the destination open.

@mafintosh
Copy link
Owner

Not gonna support end: false as thats a massive footgun, but totally fine to throw if someone does it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants