Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR for typescript definition? #97

Closed
alvis opened this issue Nov 8, 2018 · 4 comments · May be fixed by #153
Closed

PR for typescript definition? #97

alvis opened this issue Nov 8, 2018 · 4 comments · May be fixed by #153

Comments

@alvis
Copy link

alvis commented Nov 8, 2018

@mafintosh: Do you accept a typescript definition PR for tar-stream?
I have one working at https://github.com/alvis/tar-stream/tree/typescript

It would be great if the definition is attached at the source, as any incompatible change can be detected by the test.
But I'm aware that some authors prefer not to have the definitions attached at the source. If it's the case, I'd submit it to DefinitelyTyped instead.
@mafintosh
Copy link
Owner

What do I need to do to help you support this?

@alvis
Copy link
Author

alvis commented Nov 8, 2018 •
edited

@mafintosh nothing. I've got everything working and tested. :)

@alvis
Copy link
Author

alvis commented Feb 6, 2019

ping @mafintosh: happy to accept a PR?

@mafintosh
Copy link
Owner

feel free to pr typings if relevant

@alvis alvis mentioned this issue Jun 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add typescript definition alvis/tar-stream
2 participants
@mafintosh @alvis