Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] More room for Secrets name so it isn't cut off. Auto-fit? #5066

Closed
amlloyd opened this issue May 14, 2024 · 2 comments
Closed

[FEATURE REQUEST] More room for Secrets name so it isn't cut off. Auto-fit? #5066

amlloyd opened this issue May 14, 2024 · 2 comments
Assignees
@johnson-mage
Labels
enhancement Polish or UX improvements

Comments

@amlloyd
Copy link

amlloyd commented May 14, 2024

Is your feature request related to a problem? Please describe.
Secrets' names are cut off even though plenty of room. Theses names are far more important to see than the "********".

Describe the solution you'd like
Requesting that the dynamic column width favors the secret name rather than having a ton of whitespace in the value area.

image
@johnson-mage johnson-mage self-assigned this May 14, 2024
@johnson-mage johnson-mage added the enhancement Polish or UX improvements label May 14, 2024
@johnson-mage
Copy link
Member

@amlloyd Got it, we'll make this improvement.

@johnson-mage johnson-mage mentioned this issue May 15, 2024
Merged
5 tasks
@johnson-mage
Copy link
Member

Addressed in #5072. Will be available in next version of Mage.

johnson-mage added a commit that referenced this issue May 15, 2024
@johnson-mage
[jk] Improve visibility of variable/secret names (#5072)
d815d5a 
# Description
- Long secret and variable names in the Sidekick of the Pipeline Editor
were getting cut off with no way to read them if the clipboard was
blocked. This PR makes the variable/secret names fully visible, also
adding tooltips, even if there is no access to the browser's clipboard.
- Addresses #5066

# How Has This Been Tested?
Before:

![image](https://github.com/mage-ai/mage-ai/assets/78053898/86612dfd-5171-421c-a278-0a3fe917843e)

![image](https://github.com/mage-ai/mage-ai/assets/78053898/e2fee119-eb82-4c00-abc5-2ab622214cd9)

After:

![image](https://github.com/mage-ai/mage-ai/assets/78053898/bc820069-5045-415d-b433-b999faebde67)

![image](https://github.com/mage-ai/mage-ai/assets/78053898/8f2f4a7d-1c47-45c0-890a-73215e4aea40)

# Checklist
- [X] The PR is tagged with proper labels (bug, enhancement, feature,
documentation)
- [X] I have performed a self-review of my own code
- [ ] I have added unit tests that prove my fix is effective or that my
feature works
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation

cc:
<!-- Optionally mention someone to let them know about this pull request
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnson-mage johnson-mage

Labels
enhancement Polish or UX improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amlloyd @johnson-mage