Update ComposerInformation for Mage-OS vendor name #42
Assignees
Comments
Vinai
changed the title
Vinai
added a commit
to Vinai/mageos-magento2
that referenced
this issue
Oct 8, 2023
The ComposerInformation class is used to extract information about the current installation from the project root composer.json and composer.lock files, for example the Magento version. To find the relevant information, it looks at the package names, using a vendor name magento. Without this change, the installed version is reported as "UNKNOWN" in the Magento admin when the mage-os/project-community-edition package is used. This change fixes the regex so it correctly identifies the installed version. In future, it may be worth generalizing this so it is easier to switch the project vendor for other distributions based on Mage-OS. Fixes issue mage-os#42.
5 tasks
Vinai
added a commit
that referenced
this issue
Oct 8, 2023
The ComposerInformation class is used to extract information about the current installation from the project root composer.json and composer.lock files, for example the Magento version. To find the relevant information, it looks at the package names, using a vendor name magento. Without this change, the installed version is reported as "UNKNOWN" in the Magento admin when the mage-os/project-community-edition package is used. This change fixes the regex so it correctly identifies the installed version. In future, it may be worth generalizing this so it is easier to switch the project vendor for other distributions based on Mage-OS. Fixes issue #42.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The class
Magento\Framework\Composer\ComposerInformationneeds to be updated so it checks for the vendor namemage-osinstead ofmagento.Preconditions and environment
Steps to reproduce
Log into the admin and inspect the footer.
Expected result
I expect to see the
Mage-OS ver. 1.0.0.Actual result
I see
Mage-OS ver. UNKNOWN.Additional information
There are a number of regular expressions that need to be updated so they match the vendor-name
mage-os:\Magento\Framework\Composer\ComposerInformation::getRequiredPhpVersion\Magento\Framework\Composer\ComposerInformation::isSystemPackage\Magento\Framework\Composer\ComposerInformation::isMagentoRootAlso, the tests in
dev/tests/integration/testsuite/Magento/Framework/Composer/ComposerInformationTest.phpneed to be adjusted accordingly.The text was updated successfully, but these errors were encountered: