Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a Github Action that runs the the semantic version checker as defined by https://developer.adobe.com/commerce/testing/guide/svc/ #5

Open
damienwebdev opened this issue Oct 28, 2022 · 8 comments

Comments

@damienwebdev
Copy link
Member

No description provided.

@lefte
Copy link
Contributor

lefte commented Oct 31, 2022

So, the semver checker tool wants to compare whatever changes you have against a known version or tag. I don't see a way to have it auto-determine which version your new change or branch should validate against, so should I just hard-code it to 2.4-develop for now, and we'll just bump it manually as new (or old) versions are added?

From the instructions:

  1. Navigate the magento-semver folder and run the Semantic Version Checker compare command:
    bin/svc compare ../magento2-mainline ../magento2
    The first parameter is the mainline code without any changes, and the second parameter is the path to the folder with your changes. The results of the Semantic Version Checker are outputted to the console.

@lefte
Copy link
Contributor

lefte commented Oct 31, 2022

Unrelated question: Check semver on every push, on pull requests, what trigger do we want to use?

@damienwebdev
Copy link
Member Author

On PRs only currently, comparing the diff of the PR against the original HEAD.

@lefte
Copy link
Contributor

lefte commented Nov 1, 2022

MageOS Semantic Checker

See the following potential pull request into the MageOS repo: 2.4-develop...lefte:magento2:feature/issue-5-github-action-semantic-checker

Would this be the right spot to create a PR to?

@lefte
Copy link
Contributor

lefte commented Nov 1, 2022

On PRs only currently, comparing the diff of the PR against the original HEAD.

Hopefully this is what you meant, it compares the new pull request's head branch against the base branch

@damienwebdev
Copy link
Member Author

@lefte this is exactly it! Thank you so so so much!

@lefte
Copy link
Contributor

lefte commented Nov 2, 2022

🚯 Ah, I see it doesn't like pull requests from forked repositories, let me check on which variable to use for that

@lefte
Copy link
Contributor

lefte commented Nov 2, 2022

Alright, I believe the newest action https://github.com/mage-os/mageos-magento2/actions/runs/3374600139 should now work with forked repositories. Thanks for your patience.

Vinai pushed a commit that referenced this issue Dec 6, 2022
Vinai added a commit that referenced this issue Dec 6, 2022
…tic-checker

Issue #5 GitHub Action Semantic Checker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants