Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix erroneous docstring of sh.Exec() #452

Merged
merged 2 commits into from Mar 6, 2023
Merged

fix erroneous docstring of sh.Exec() #452

merged 2 commits into from Mar 6, 2023

Conversation

omarkohl
Copy link
Contributor

sh.Exec() uses the passed in stderr io.Writer to write the stderr output not "piping its stderr to mage's stderr".

@omarkohl
fix erroneous docstring of sh.Exec()
2a6c69f 
sh.Exec() uses the passed in stderr io.Writer to write the stderr output
not "piping its stderr to mage's stderr".
natefinch
natefinch approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@natefinch natefinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@natefinch natefinch merged commit 9199872 into magefile:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natefinch natefinch natefinch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@omarkohl @natefinch