Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Store Pickup email still using legacy methods #3384

Open
smartexcan opened this issue May 24, 2023 · 1 comment · May be fixed by #3385
Open

In Store Pickup email still using legacy methods #3384

smartexcan opened this issue May 24, 2023 · 1 comment · May be fixed by #3385
Assignees
Projects

Comments

@smartexcan
Copy link

smartexcan commented May 24, 2023

The In Store Pickup "Ready for pickup" notification email still uses deprecated (and removed as of magento 2.4.4) variables with direct method calls.
This results in the affected variables in the email template not being rendered.

See https://developer.adobe.com/commerce/frontend-core/guide/templates/email-migration/

Preconditions (*)

  1. Magento 2.4.4

Steps to reproduce (*)

  1. Place order with in-store-pickup
  2. Send ready for pickup notification email.

Expected result (*)

  1. Email with all correct output (store name, customer name, shipping description)

Actual result (*)

  1. Customer name is not rendered.
@m2-assistant
Copy link

m2-assistant bot commented May 24, 2023

Hi @smartexcan. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added this to Ready for Grooming in Backlog May 24, 2023
@smartexcan smartexcan linked a pull request May 24, 2023 that will close this issue
4 tasks
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Pull Request In Progress in Backlog May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Backlog
  
Pull Request In Progress
Development

Successfully merging a pull request may close this issue.

1 participant