Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate in-store-pickup email to strict mode #3385

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

smartexcan
Copy link

Description (*)

The In Store Pickup "Ready for pickup" notification email still used deprecated (and removed as of magento 2.4.4) variables with direct method calls.
This resulted in the affected variables in the email template not being rendered.

Fixed Issues (if relevant)

  1. Fixes In Store Pickup email still using legacy methods #3384

Manual testing scenarios (*)

  1. Create order with in-store-pickup
  2. Send ready for pickup email
  3. Check email output for customer name.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Pull Request Progress
  
Ready for Review
Development

Successfully merging this pull request may close these issues.

In Store Pickup email still using legacy methods
1 participant