-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widget not inserting or saving when the word 'type' is used anywhere in the text after a quotation mark #38711
Comments
Hi @matthewjdewhurst-fw. Thank you for your report.
Join Magento Community Engineering Slack and ask your questions in #github channel. |
@magento give me 2.4-develop instance |
Hi @matthewjdewhurst-fw. Thank you for your request. I'm working on Magento instance for you. |
Hi @matthewjdewhurst-fw, here is your Magento Instance: https://b9810516d0531629e4febc1d68d7fbe8.instances-prod.magento-community.engineering |
I've just tested on the Magento instance provided and can confirm that it's still happening. |
Hi @engcom-November. Thank you for working on this issue.
|
Hello @matthewjdewhurst-fw, Thank you for the report and collaboration! Verified this on 2.4-develop instance with default luma theme.
The widget is not being saved. Thank you. |
✅ Jira issue https://jira.corp.adobe.com/browse/AC-11939 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-November. Thank you for verifying the issue. |
I reproduced on a Magento CE 2.4.7 (if it helps) |
Hi Medmek, Thanks for confirming. I've spotted your answer on the Magento Stack Exchange. The file and line you have referred to is definitely a step in the right direction, and I think we have a partial fix here. I've left a few comments on your answer, but I'll summarise here: Line 715 in lib/web/mage/adminhtml/wysiwyg/tiny_mce/tinymce5Adapter.js:
|
Thanks for the exchange, and your comments where a huge help, I hope the EDIT works for you. |
Potentially. I haven't had chance to do any comprehensive testing yet. But from simply commenting that one line out, the widget appeared to be saving and loading absolutely fine as long as you didn't press the "Show/Hide Editor" button. In our use case, we're going to be hiding the "Show/Hide Editor" button before the site goes to production. So this could be a solution for us, but not a solution to the problem at large. As soon as I get the chance, I'll do some more testing and get back to this thread. |
Summary
Hi. For a little context, we have recently made the decision to disable page builder and move towards a component-driven content entry approach utilising widgets. We have a "Generic Text" widget, which consists of a custom WYSIWYG parameter.
Whilst testing this widget, we came across a rather odd (and probably quite specific) problem, which is that if a quotation mark is present in the text, and then the word
type
is present anywhere in the preceding text, the widget fails to insert or save and completely disappears from the editor.Obviously we have some custom functionality going on here, but what I have observed is that this is also an issue with the standard Magento widgets where a text field is present. e.g. CMS Page Link, Catalog Product Link. Which leads me to believe this might not be related or our setup alone.
Environment
Errors
Examples
Steps to reproduce
Ensure Page Builder is disabled, and you're using the standard TinyMCE editor.
" type
into 'Anchor Custom Text'You should find that the widget modal retracts, and you're left with:
The same happens when trying to save a widget which existing content:
" type
and save it), or edit an existing widget" type
is now includedProposed solution
The widget should insert/save as normal.
Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: